BE: Issue#1332 Sort based on prefix offsets #1421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
2 tasks
There was a problem hiding this comment.
Pull Request Overview
This pull request implements sorting functionality based on prefix offsets for Lucene topic search. The changes improve search result ranking by prioritizing matches where search terms appear earlier in topic names.
- Introduces a custom scoring function that calculates position-based scores for search prefixes
- Adds support for offset tracking in the word analyzer and text field indexing
- Implements comprehensive test coverage for the new ordering functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ShortWordAnalyzer.java | Modified to support offset tracking and moved to lucene package |
| IndexedTextField.java | New custom text field implementation with offset support |
| NameDistanceScoringFunction.java | New scoring function that ranks results by prefix position |
| PrefixQueryParser.java | Enhanced to track search prefixes for scoring |
| LuceneTopicsIndex.java | Updated to use new components and apply position-based scoring |
| ShortWordAnalyzerTest.java | New test class validating analyzer offset behavior |
| LuceneTopicsIndexTest.java | Enhanced with ordering tests and moved to lucene package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
api/src/main/java/io/kafbat/ui/service/index/lucene/NameDistanceScoringFunction.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/index/lucene/NameDistanceScoringFunction.java
Show resolved
Hide resolved
api/src/test/java/io/kafbat/ui/service/index/lucene/LuceneTopicsIndexTest.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/index/LuceneTopicsIndex.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)